[MAGNOLIA-3586] Sizing of DialogEditCode in code-highlighting mode should be configurable Created: 04/Mar/11  Updated: 16/Aug/11  Resolved: 15/Aug/11

Status: Closed
Project: Magnolia
Component/s: gui
Affects Version/s: None
Fix Version/s: 4.4.5

Type: Bug Priority: Neutral
Reporter: Daniel Lipp Assignee: Federico Grilli
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File patch.diff    
Issue Links:
relation
is related to MGNLGROOVY-43 Update dialog configuration Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Height of type DialogEditCode is hardcoded to 420px when using code highlighting. Behavior should be consistent - independent from highlighting, the attributes rows & cols should be usable to configure the size of the element.



 Comments   
Comment by Scrivo Codice [ 19/Apr/11 ]

There's my patch and it seems to work

Cheers
SC

Comment by Magnolia International [ 19/Apr/11 ]

Thanks for the patch !

Comment by Magnolia International [ 15/Aug/11 ]

The configuration attribute is called rows. Despite the name, the value of that attribute is used to configure the height in pixels ! Breaks all existing configurations.
Either use a different attribute, or keep it equivalent to a number of rows.
The default dialog for the inline templating has a value of "28" for this, making it completely useless, barely showing one line ...
Same goes for the resources module's dialog.

Comment by Federico Grilli [ 15/Aug/11 ]

darn, have to port it to trunk

Generated at Mon Feb 12 03:47:52 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.