[MAGNOLIA-3591] Original previewMode is forgotten when Exception in Paragraph Created: 08/Mar/11  Updated: 19/Dec/16  Resolved: 04/Nov/15

Status: Closed
Project: Magnolia
Component/s: rendering, templating
Affects Version/s: 4.4.2
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Kimmo Björnsson Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MAGNOLIA-3687 RenderingEngine does not restore aggr... Closed
Template:
Patch included:
Yes
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

When I use noEditBars="true" and the Paragraph throws an Exception all paragraphs afterwards get no edit-bar.

I found that the last part that restores the previewMode is not run when an Exception is thrown in this code.

           if(noEditBars && !orgShowPreview){
               aggregationState.setPreviewMode(true);
           }

           if (this.path != null) { // TODO
               log.warn("You are using the deprecated path attribute
of the include tag. Your jsp will be included for now, but you might
want to update your code to avoid bad surprises in the future.");
               pageContext.include(this.path);
           } else {
               WebContext webContext = MgnlContext.getWebContext();
               webContext.setPageContext(pageContext);

webContext.push((HttpServletRequest)pageContext.getRequest(),
(HttpServletResponse)pageContext.getResponse());
               try {
                   renderingEngine.render(content, pageContext.getOut());
               } finally{
                   webContext.pop();
                   webContext.setPageContext(null);
               }
           }
           if(noEditBars){
               aggregationState.setPreviewMode(orgShowPreview);
           }


 Comments   
Comment by Philipp Bärfuss [ 09/Mar/11 ]

Thanks for all the debugging

Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 03:47:55 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.