[MAGNOLIA-3607] Login form field labels are hardcoded - allow translating them! Created: 12/Apr/11  Updated: 04/Mar/19  Resolved: 04/Aug/15

Status: Closed
Project: Magnolia
Component/s: admininterface, i18n
Affects Version/s: 4.4.2
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Magnolia International Assignee: Unassigned
Resolution: Outdated Votes: 0
Labels: i18n
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

magnolia-module-admininterface/src/main/resources/mgnl-resources/loginForm/login.html has hardcoded text for the "username", "password" fields, the "login" button, and the page's title. (while the error messages are i18n'd)

Additionally, if info.magnolia.cms.security.auth.callback.FormClientCallback, one could customize the naming of those fields as well as customize the error messages (for example enabling the display of specific login exceptions with messages such as login.AccountLockedException = This account is locked. Please contact an administrator if you feel this is wrong.)



 Comments   
Comment by Philipp Bärfuss [ 12/Apr/11 ]

I know it isn't a superior solution but you can subclass FormClientCallback and override getMessages() or use a different template if one wants to change the form.

To achieve more flexibility one would override doCallback and pass the i18nBasename.

But I don't think we are going to change that for the 4.x series.

Comment by Magnolia International [ 03/Dec/13 ]

IIRC, login.html was not using i18n for the above mentioned fields - modules/admininterface-legacy/src/main/resources/mgnl-resources/loginForm/login.html seems to confirm this with stuff like

<label for="username">Username</label>

magnolia_ui/magnolia-ui-admincentral/src/main/resources/mgnl-resources/defaultLoginForm/login.html is similar in that respect (and doesn't even capitalize the text, which is currently done via css)

While customizing might indeed be a stretch, they should be translated !

Comment by Michael Mühlebach [ 04/Aug/15 ]

We're closing this issue as outdated as it was reported for 4.4.x or earlier versions which are no longer supported. Don't hesitate to reopen or create a new ticket in case this is still relevant and you'll experience it on 4.5.x or later versions.

Generated at Mon Feb 12 03:48:04 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.