[MAGNOLIA-3670] Provide varags method in DeltaBuilder Created: 26/Apr/11  Updated: 04/Mar/19  Resolved: 04/Nov/15

Status: Closed
Project: Magnolia
Component/s: core, modulemechanism
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Magnolia International Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: quickwin
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File MAGNOLIA-3670.2.patch     Text File MAGNOLIA-3670.patch    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

info.magnolia.module.delta.DeltaBuilder, like info.magnolia.module.delta.ArrayDelegateTask, could benefit from methods using vararg parameters. Here's an example patch.



 Comments   
Comment by Magnolia International [ 03/Dec/13 ]

Here's an update patch that applies on current master. I would however reconsider and perhaps deprecate the DeltaBuilder.update method which takes Task arguments - 1) they have no install equivalent, and it looks like they're not used. (because redundant with .addTask(s))

curl <patch-url> | patch -p 0

Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 03:48:34 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.