[MAGNOLIA-3691] Remove incorrect warnings Created: 16/May/11 Updated: 04/Oct/12 Resolved: 03/Oct/12 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | 4.4.3 |
| Fix Version/s: | 4.5.5 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Ondrej Chytil | Assignee: | Roman Kovařík |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||
| Description |
|
DialogHandlerManager is not checking just dialog nodes for type contentNode but also some folders where those dialogs are stored. Those messages should be removed as they are just messing log with incorrect info. Dialog definitions should be of type contentNode but [/modules/standard-templating-kit/dialogs/generic/pages] is of type content. 2011-05-06 16:39:53,546 WARN agnolia.module.admininterface.DialogHandlerManager: Dialog definitions should be of type contentNode but [/modules/standard-templating-kit/dialogs/generic/controls] is of type content. 2011-05-06 16:39:53,546 WARN agnolia.module.admininterface.DialogHandlerManager: Dialog definitions should be of type contentNode but [/modules/standard-templating-kit/dialogs/generic/teasers] is of type content. 2011-05-06 16:39:53,560 WARN agnolia.module.admininterface.DialogHandlerManager: Dialog definitions should be of type contentNode but [/modules/categorization/dialogs/generic] is of type content. |
| Comments |
| Comment by Jan Haderka [ 19/Jul/11 ] |
|
Remove the warning in next major version. |
| Comment by Eric Hechinger [ 15/Mar/12 ] |
|
This is due to this part of code (ConfiguredDialogHandlerManager): for: /modules/standard-templating-kit/dialogs/generic/pages // if one subnode is a control } protected boolean isDialogControlNode(Content node) throws RepositoryException { return node.hasNodeData("controlType") || node.hasNodeData("reference"); }
|
| Comment by Jan Haderka [ 01/Oct/12 ] |
|
I don't think it's quite that simple. We still need the warning if there are real dialogs that are of incorrect type. So rather then changing log level we need to devise better condition for logging this warning that will not be fooled by folder containing dialogs. |