[MAGNOLIA-3705] Code higlight editor: crashed on styles.css (many lines) in most browsers Created: 19/May/11  Updated: 16/Dec/14  Resolved: 28/Feb/14

Status: Closed
Project: Magnolia
Component/s: gui
Affects Version/s: 4.4
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Christian Ringele Assignee: Federico Grilli
Resolution: Outdated Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MAGNOLIA-3702 Upgrade to latest CodeMirror js library Closed
is related to MAGNOLIA-6011 Cannot able to add FTL code more than... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

When opening the STK's styles.css within the resources module, most browsers crash.
It seems that the code highlighting is the cause.

Summary of tested browsers:
Browser / Windows / OsX
Firefox 4.0: crash / works
Chrome: crash / crash
IE 8.0: works / -
Safari 5: - / crash



 Comments   
Comment by Federico Grilli [ 19/May/11 ]

Hi Christian, I quickly tested it on our demo author with OS X and the latest versions of Firefox, Chrome and Safari: never crashed. Sometimes it takes couple of secs to show the code and not all seems to be colored. But apart from that, it seems to work fine. However since version 2.0 of code mirror (the js library doing syntax highlighting) has been released and this is said to be a complete and more performant rewrite of it, I'll file a jira to upgrade to the latest version of it.

Comment by Christian Ringele [ 19/May/11 ]

Hi Federico,

That is really strange, just encountered it in training, and all participants had that behavior. We tested it on 2 Windows and 3 Mac machines, all the same behavior, really crashes of the browsers. Probably there is a difference, if it is server trough eclipse/IDE and not deployed in a tomcat as a standard installation (as our demo)?

Comment by Christian Ringele [ 19/May/11 ]

By the way, sometimes you need to paste or write something at the bottom. I think in chrome it crashed only then.

Comment by Federico Grilli [ 20/May/11 ]

That's weird. I remember having tested the new code editor (on my dev machine, thus serving the app from eclipse) precisely with that large file and everything went always smooth. Most likely it is a memory problem and by assigning more memory to tomcat and eclipse the issue would go. I'll reopen the issue and try to reproduce it on my dev machine. In any case, upgrading to CodeMirror 2.0 should bring overall better performance and fix several issues.

Generated at Mon Feb 12 03:48:54 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.