[MAGNOLIA-3727] Remove confusing error message printed when using extends=override feature Created: 06/Jun/11  Updated: 17/Aug/11  Resolved: 17/Aug/11

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 4.4.4
Fix Version/s: 4.4.5

Type: Bug Priority: Major
Reporter: Zdenek Skodik Assignee: Jan Haderka
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File openme.png    
Issue Links:
causality
caused by MAGNOLIA-3353 Extends feature breaks templates&dial... Closed
relation
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Changes done for MAGNOLIA-3353 (and its subtasks) on one hand unbend the original breaks, on the other logs an useless error for the extends=override use case since the if/else branch for it is never reached because the previous two branches serve it all. It doesn't (or shouldn't) break the functionality itself as the extending=false; is set anyway.

To fix it just change the ordering - move EXTENDING_NODE_DATA_OVERRIDE.equals(extendedNode) condition prior to the above one, or maybe even at the beginning.



 Comments   
Comment by Jan Haderka [ 15/Aug/11 ]

I think the code could be made simpler while we are at it as well.

Generated at Mon Feb 12 03:49:06 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.