[MAGNOLIA-3747] calendar.js contains an error Created: 29/Jun/11  Updated: 04/Aug/15  Resolved: 04/Aug/15

Status: Closed
Project: Magnolia
Component/s: admininterface
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Adrien Berthou Assignee: Philipp Bärfuss
Resolution: Outdated Votes: 0
Labels: admininterface, author, javascript, magnolia
Remaining Estimate: 1d
Time Spent: Not Specified
Original Estimate: 1d

Template:
Patch included:
Yes
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

I believe the javascript that is used to add a calendar feature (calendar.js) contains an error:

Error: too much recursion
Source File: http://<domainName>/magnoliaAuthor/.resources/calendar/calendar.js
Line: 1797

I bumped into this as I added a "custom" calendar to my website using some javascript. At some point in this "custom" calendar I do a call on the setFullYear(Y) function of the Date object. That's where the error comes up (stack overflow).

It seems that calendar.js (coming from Magnolia own calendar) is redefining this Date.setFullYear(Y) function for some reason! And it does it badly which creates a stack overflow

This issue only comes up in IE I believe - I tried with IE8 and below and it came up every time. Chrome seem to manage this issue and I believe Firefox too. It would have to be checked though.

+ It looks like the error is fixable, see http://community.zikula.org/module-Forum-viewtopic-topic-57870.htm

  • Replace the following:
    Date.prototype.__msh_oldSetFullYear = Date.prototype.setFullYear;
  • With:
    if( Date.prototype.__msh_oldSetFullYear == null ) { Date.prototype.__msh_oldSetFullYear = Date.prototype.setFullYear; }


 Comments   
Comment by Michael Mühlebach [ 04/Aug/15 ]

We're closing this issue as outdated as it was reported for 4.4.x or earlier versions which are no longer supported. Don't hesitate to reopen or create a new ticket in case this is still relevant and you'll experience it on 4.5.x or later versions.

Generated at Mon Feb 12 03:49:18 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.