[MAGNOLIA-3748] An *update* should also apply conditions on web.xml (checking dispatchers for example) Created: 01/Jul/11  Updated: 15/Aug/11  Resolved: 27/Jul/11

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 4.4.4
Fix Version/s: 4.4.5

Type: Bug Priority: Critical
Reporter: Magnolia International Assignee: Daniel Lipp
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
caused by MAGNOLIA-3338 Context is not updated on include req... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

Since MAGNOLIA-3338, we have an install condition, checking that all necessary dispatchers are setup in the web.xml file. This should also be checked on updates !

When extending AbstractModuleVersionHandler, this can be done two ways:

    // these conditions will only be checked when applying this specific version update:
    register(DeltaBuilder.update(...)
      .addCondition(...)
      .addTask(...)
      ...
    );

    // these conditions will be applied for each update (i.e applied N times if we update across N versions)
    @Override
    protected List<Condition> getDefaultUpdateConditions(Version forVersion) {
        return Arrays.asList(...);
    }


 Comments   
Comment by Magnolia International [ 10/Aug/11 ]

Can we please add an inline comment in the code that points out that this change (dispatchers) wasn't done in 4.4.5 and indicate when it should have been done instead ? Perhaps even add the condition to that delta as well.

Generated at Mon Feb 12 03:49:18 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.