Add MimeMappings config for .m4a, .m4v, and .srt
(MAGNOLIA-3730)
|
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | core |
| Affects Version/s: | None |
| Fix Version/s: | 4.4.5 |
| Type: | Sub-task | Priority: | Neutral |
| Reporter: | Natascha Desmarais | Assignee: | Natascha Desmarais |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | mimemapping, mimetype | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
As a subtask of From the same issue, the following types will be added as suggested by M. Dertinger <mime-mapping> <extension>m4b</extension> <mime-type>audio/mp4</mime-type> </mime-mapping> <mime-mapping> <extension>m4r</extension> <mime-type>audio/mp4</mime-type> </mime-mapping> <mime-mapping> <extension>mp4a</extension> <mime-type>audio/mp4</mime-type> </mime-mapping> <mime-mapping> <extension>mp4s</extension> <mime-type>application/mp4</mime-type> </mime-mapping> <mime-mapping> <extension>mp4v</extension> <mime-type>video/mp4</mime-type> </mime-mapping> <mime-mapping> <extension>mpg4</extension> <mime-type>video/mp4</mime-type> </mime-mapping> |
| Comments |
| Comment by Natascha Desmarais [ 28/Jul/11 ] |
|
Added all necessary bootstraps, update tasks and tests |
| Comment by Natascha Desmarais [ 05/Aug/11 ] |
|
Change update method to BootstrapConditionally(..) |
| Comment by Natascha Desmarais [ 05/Aug/11 ] |
|
Changed update method to BootstrapConditionally(..) and removed unused task |
| Comment by Magnolia International [ 07/Sep/11 ] |
|
Update tasks are registered with a description not written in the 3rd person and not ending with a period symbol (should be "Bootstraps MIME mapping for m4b in case it doesn't exist already." instead of "Bootstrap MIME mapping for m4b in case it doesn't exist already"). While that's a minor inconvenience, while looking at how the tasks had been implemented, I noticed we use bootstrap tasks instead of using AddMimeMappingTask which was designed for that purposed, afaik. Any reason ? |
| Comment by Natascha Desmarais [ 08/Sep/11 ] |
|
Adding would create different uuids - with that amount that needed to be added in the parent task + this one it seemed more reasonable to bootstrap instead. |
| Comment by Magnolia International [ 08/Sep/11 ] |
|
Not sure I see why a different uuid (different from what ?) would be a problem. Either way, the descriptions should be improved. |
| Comment by Jan Haderka [ 08/Sep/11 ] |
|
Different UUID between author and public could be indeed an issue if you are trying to activate those mappings which some customers do. Edit: Ooops missed your earlier comment. The task description should indeed end with the punctuation sign as every normal sentence does. |
| Comment by Natascha Desmarais [ 08/Sep/11 ] |
|
Wrote proper update task description. |