[MAGNOLIA-3884] cmsu:AHref always use default extension Created: 15/Nov/11 Updated: 11/Nov/15 Resolved: 11/Nov/15 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | taglibs |
| Affects Version/s: | 4.4.5 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Lauri | Assignee: | Fabrizio Giustina |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
| Template: |
|
| Patch included: |
Yes
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Date of First Response: |
| Description |
|
cmsu:ahref works with default extension only. This might be incorrect behaviour. Extension output section is AHref.java if (MgnlContext.getHierarchyManager(ContentRepository.WEBSITE).isPage(path)) { out.print("."); //$NON-NLS-1$ out.print(ServerConfiguration.getInstance().getDefaultExtension()); } If site is running multiple extensions .getDefaultExtension() might be handicap. I.e. case when xml refers to another xml. Suggested workaround is to add additional attribute to ahref tag which will enforce some particular extension, i.e. <cmsu:ahref .... extension="xml">link</cmsu:ahref>. See patch. Patched AHref.java if (MgnlContext.getHierarchyManager(ContentRepository.WEBSITE).isPage(path)) { out.print("."); //$NON-NLS-1$ out.print(extension == null ? ServerConfiguration.getInstance().getDefaultExtension() : extension); } Forum link: |
| Comments |
| Comment by Lauri [ 15/Nov/11 ] |
|
P.s. somehow magnolia refuses to build here, so no test case provided. |
| Comment by Lauri [ 17/Nov/11 ] |
|
ahref-extension-1.patch is the patch w/o code style changes. |
| Comment by Michael Mühlebach [ 11/Nov/15 ] |
|
Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes. |