[MAGNOLIA-3926] RedirectClientCallback should not lose parameters when redirecting to the login form Created: 22/Dec/11 Updated: 06/Apr/19 Resolved: 03/Jan/12 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | core |
| Affects Version/s: | 4.4.2 |
| Fix Version/s: | 4.4.6, 4.5 |
| Type: | Bug | Priority: | Major |
| Reporter: | Will Scheidegger | Assignee: | Ondrej Chytil |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | callback, client, core, login, parameters | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Patch included: |
Yes
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||
| Date of First Response: | |||||||||||||
| Description |
|
When a page with parameters is called, which requires the user to log in first, and a RedirectClientCallback handles the forwarding to the login form, then all parameter infos are lost. The attached patch adds the parameters to the url string in order for the login. It also removes any "mgnlLogout" parameters since these would not make much sense on login requests. |
| Comments |
| Comment by Will Scheidegger [ 22/Dec/11 ] |
|
While the patch works very well for what I have tested, it appears fail in the unit tests. So I guess I need to study the unit tests and provide a new patch. |
| Comment by Will Scheidegger [ 22/Dec/11 ] |
|
This patch now works with the unit tests... although there is no unit test now for the case this patch fixes (redirect with parameters) |
| Comment by Ondrej Chytil [ 03/Jan/12 ] |
|
Thanks for patch Will. |