[MAGNOLIA-3930] saveLabel and cancelLabel cannot be configured with i18n Created: 30/Dec/11  Updated: 04/Aug/15  Resolved: 04/Aug/15

Status: Closed
Project: Magnolia
Component/s: admininterface, gui
Affects Version/s: 4.4.2, 4.4.3, 4.4.4, 4.4.5
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Richard Unger Assignee: Unassigned
Resolution: Outdated Votes: 0
Labels: i18n
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File Dialog.java.patch    
Template:
Patch included:
Yes
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

The dialog configuration fields saveLabel and cancelLabel cannot be internationalized.

While all other dialog labels (for controls, tabs. etc...) can be internationalized, cancelLabel and saveLabel cannot.

They use either the configured value directly, or if no value is configured, they use the default label (which is i18n).

This should be changed to allow i18n for these labels. A patch is attached.

See info.magnolia.cms.gui.dialog.Dialog.java, lines 260 and 270.



 Comments   
Comment by Michael Mühlebach [ 04/Aug/15 ]

We're closing this issue as outdated as it was reported for 4.4.x or earlier versions which are no longer supported. Don't hesitate to reopen or create a new ticket in case this is still relevant and you'll experience it on 4.5.x or later versions.

Generated at Mon Feb 12 03:51:03 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.