[MAGNOLIA-3937] Password shows up in log on CacheFilter warning Created: 06/Jan/12  Updated: 04/Mar/15  Resolved: 12/Jan/12

Status: Closed
Project: Magnolia
Component/s: cache
Affects Version/s: 4.4.4
Fix Version/s: 4.4.6, 4.5

Type: Bug Priority: Critical
Reporter: David Pronk Assignee: Ondrej Chytil
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLCACHE-90 CacheFilter should not log cache keys Closed
relation
is related to MAGNOLIA-3802 Activation error messages provide too... Closed
is related to MAGNOLIA-3998 Password for new public user shows up... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

When running Magnolia 4.4.4 Enterprise Edition on my development environment using jetty 7.2.0.v20101020 this warning sometimes shows up:

2012-01-06 10:31:24,038 WARN info.magnolia.module.cache.filter.CacheFilter : The following URL took longer than 10 seconds (13) to render. This might cause timout exceptions on other requests to the same URI. [url=http://localhost:8085/cluster/mysamplesite], [key=DefaultCacheKey{uri='/mysamplesite', serverName='localhost', locale='nl', params={mgnlUserId=d.pronk, mgnlUserPSWD=myPassword}}]

My password should not be exposed here.



 Comments   
Comment by Jan Haderka [ 09/Jan/12 ]

Thx for reporting the issue.

Comment by Daniel Lipp [ 10/Jan/12 ]

Unittest?

Comment by Ondrej Chytil [ 11/Jan/12 ]

Method removing password from logs should be moved to SecurityUtil class.

Generated at Mon Feb 12 03:51:07 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.