[MAGNOLIA-3954] info.magnolia.cms.security.MgnlGroupManager.getGroup(String) throws npe when group doesn't exist Created: 30/Jan/12  Updated: 08/Mar/12  Resolved: 31/Jan/12

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: None
Fix Version/s: 4.5

Type: Improvement Priority: Blocker
Reporter: Milan Divilek Assignee: Milan Divilek
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File stacktrace    
Issue Links:
relation
is related to MAGNOLIA-3938 Provide page to list effective roles,... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

info.magnolia.cms.security.MgnlGroupManager.getGroup(String) throws npe when group doesn't exist. It should be changed to return some warn, but not fail on this exception



 Comments   
Comment by Federico Grilli [ 31/Jan/12 ]

When installing the EE webapp this seems to cause

[INFO] [talledLocalContainer] 2012-01-31 17:33:30,493 ERROR info.magnolia.module.InstallContextImpl           : > Error while installing or updating workflow module. Task 'Add superuser to the publishers group' failed. (NullPointerException: )
[INFO] [talledLocalContainer] java.lang.NullPointerException
[INFO] [talledLocalContainer] 	at info.magnolia.cms.security.RepositoryBackedSecurityManager.getLinkedResourceId(RepositoryBackedSecurityManager.java:191)
[INFO] [talledLocalContainer] 	at info.magnolia.cms.security.RepositoryBackedSecurityManager.add(RepositoryBackedSecurityManager.java:154)
[INFO] [talledLocalContainer] 	at info.magnolia.cms.security.MgnlUserManager.addGroup(MgnlUserManager.java:602)
[INFO] [talledLocalContainer] 	at info.magnolia.cms.security.DelegatingUserManager$10.delegate(DelegatingUserManager.java:205)
[INFO] [talledLocalContainer] 	at info.magnolia.cms.security.DelegatingUserManager$10.delegate(DelegatingUserManager.java:202)
[INFO] [talledLocalContainer] 	at info.magnolia.cms.security.DelegatingUserManager.delegateUntilNotNull(DelegatingUserManager.java:158)
[INFO] [talledLocalContainer] 	at info.magnolia.cms.security.DelegatingUserManager.addGroup(DelegatingUserManager.java:202)
[INFO] [talledLocalContainer] 	at info.magnolia.module.delta.AddUserToGroupTask.execute(AddUserToGroupTask.java:66)
[INFO] [talledLocalContainer] 	at info.magnolia.module.ModuleManagerImpl.applyDeltas(ModuleManagerImpl.java:499)

The jcr-sql2 query statement issued seems to be fine select * from [mgnl:group] where name() = 'publishers'. Is it maybe querying the wrong workspace?

Generated at Mon Feb 12 03:51:17 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.