[MAGNOLIA-4039] Rendering trees fails sometimes in webkit browsers with adblock extension enabled Created: 12/Mar/12  Updated: 03/Apr/12  Resolved: 27/Mar/12

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 4.4.6, 4.5
Fix Version/s: 4.4.7, 4.5.2

Type: Bug Priority: Critical
Reporter: Ernst Bunders Assignee: Federico Grilli
Resolution: Fixed Votes: 1
Labels: VPRO
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Chromium 17.0.963.78 ubuntu linux


Attachments: PNG File Selectie_014.png    
Issue Links:
duplicate
is duplicated by MAGNOLIA-4114 Adblocker extension on Safari causes ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Visible to:
Mathijn Elhorst, Michiel Meeuwissen, Nils Breunese, Rico Jansen

 Description   

I disable all my extensions, it works ok.
I enable the adblock extension, some of the time rendering a tree view fails (see screenshot)

It looks like a timing issue.

We also see this in Chrome on a mac.

This bug shows itself since the update from 4.4.4 to 4.4.6



 Comments   
Comment by Magnolia International [ 13/Mar/12 ]

I noticed the same symptoms on Safari (didn't go as far as debugging that, though), but it seems to me it only happened with an update of AdBlock itself, rather than an update of Magnolia. (i.e started happening on documentation a month-or-so ago, while the instance hasn't been updated in a long while)

Comment by Ernst Bunders [ 14/Mar/12 ]

Hi Grégory
In my perception it started exactly at the moment we updated magnolia, but I can't say for sure there was not an update of adblock at the same time.

regards,
Ernst

Comment by Christopher Zimmermann [ 19/Mar/12 ]

I investigated this a little in Chrome.
I'm confirming that on my Chrome - the tree renders when AdBlock is turned off, and does not display when AdBlock is turned on.

Using Chrome Developer Tools revealed that the tree elements are still on the page. But there was no obvious indication in the markup or css of why they were not displaying. For example visibility was set to "visible" and display was not set to "none".

Here is an example of another application which was broken by Adblock.
http://code.google.com/p/adblockforchrome/issues/detail?id=6254

Comment by Federico Grilli [ 20/Mar/12 ]

I have a feeling this has to do with MAGNOLIA-3846 and the introduction of jQuery in order to call functions resizing dialogs only when DOM is ready.

Comment by Jan Haderka [ 23/Mar/12 ]

Let's see if there is simple way to fix this issue.

Comment by Federico Grilli [ 27/Mar/12 ]

Since version 2.5.19 Adblock for chrome and safari injects a fake stylesheet with null rules to solve http://code.google.com/p/adblockforchrome/issues/detail?id=6480. See also http://code.google.com/p/adblockforchrome/source/diff?spec=svn3610&r=3610&format=side&path=/trunk/adblock_start_common.js. We have to make an explicit check in code for this null rules stylesheet.

Generated at Mon Feb 12 03:52:04 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.