[MAGNOLIA-4053] Activation key check message is unclear and generates a FreeMarker exception Created: 13/Mar/12  Updated: 02/Apr/12  Resolved: 02/Apr/12

Status: Closed
Project: Magnolia
Component/s: activation, core
Affects Version/s: None
Fix Version/s: 4.5.2

Type: Bug Priority: Major
Reporter: Magnolia International Assignee: Robert Šiška
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File MAGNOLIA-4053.txt     PNG File Screen shot 2012-03-13 at 13.26.22.png    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

While attempting to upgrade the documentation project to 4.5.1, I stumbled upon this problem:

  1. The condition's message telling me that I need to have a property for the activation author key is unclear. It needs to be rewritten such that user can understand what it means, and what to do.
  2. There are two different messages (see screenshot) - the first one comes from the condition's call to installContext.error, which is perhaps not necessary.
  3. A FreeMarker exception shows in the logs, possibly because the ftl for the install screens try to get the error's exception message (which doesn't exist in this case)
    • Make those templates safer
    • Add an exception message in this case, if needed (but I suspect none of this is relevant), the condition returning false should be enough.


 Comments   
Comment by Magnolia International [ 13/Mar/12 ]

Additionally, I just realized this condition was also checked on public instances - not sure that's relevant ?

Comment by Magnolia International [ 13/Mar/12 ]

The condition is in core. Shouldn't it be in the activation module ? The activation module will use that key, and fail with Error while installing or updating exchange-simple module. Task 'Activation Keys' failed. (FileNotFoundException: /LALALA (Permission denied)) for example.

Comment by Federico Grilli [ 02/Apr/12 ]

Reopened issue as the activation message hasn't changed. Also the ftl template should be made safer by checking that the task object is actually defined before accessing it, in order to avoid ftl exceptions.

Generated at Mon Feb 12 03:52:12 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.