[MAGNOLIA-4090] VirtualUriManager should be reimplemented to extend ModuleConfigurationObservingManager Created: 22/Sep/11  Updated: 17/Feb/16  Resolved: 12/Feb/16

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: None
Fix Version/s: 5.4.5

Type: Improvement Priority: Neutral
Reporter: Tobias Mattsson Assignee: Tobias Mattsson
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 0.25h
Original Estimate: Not Specified

Issue Links:
Relates
relates to MAGNOLIA-6415 VirtualURIMapping via YAML Closed
relates to MAGNOLIA-3349 Port Virtual URI mappings to a Registry Closed
causality
is causing MAGNOLIA-6551 Binary compatibility of CommandsManag... Closed
dependency
is depended upon by MAGNOLIA-6491 Verify and if possible deprecate Obse... Closed
duplicate
is duplicated by MAGNOLIA-2263 creating or importing a virtualURIMap... Closed
is duplicated by MAGNOLIA-2579 ConcurrentModificationException in Vi... Closed
is duplicated by MAGNOLIA-4088 VirtualURIManager should reload then ... Closed
relation
is related to MAGNOLIA-3515 Better virtualUriMapping registration... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Release notes required:
Yes
Date of First Response:
Sprint: Kromeriz 30
Story Points: 3

 Description   

A restart will then no longer be required when adding the virtualURIMappings node, MAGNOLIA-2263.

It will allow us to fix the concurrency issues when configuration is reloaded, MAGNOLIA-2579 MAGNOLIA-4088.

We should also look at adding support for folders as described in MAGNOLIA-3349.



 Comments   
Comment by Mikaël Geljić [ 21/Jan/16 ]

linking to MAGNOLIA-6415; using AbstractRegistry and binding config-sources to it should actually render *ObservingManagers obsolete.

Comment by Roman Kovařík [ 22/Jan/16 ]

mgeljic The above comment/link probably belongs to MAGNOLIA-6491.

Comment by Mikaël Geljić [ 22/Jan/16 ]

Well here it's about our "client" usage of registries/managers, specifically about virtualUriMappings; At first when I saw the PR I thought we were taking the step towards the AbstractRegistry already; here now it seems we're stopping half-way through, which is fine, but eventually 6415 should probably supersede this.

Comment by Roman Kovařík [ 22/Jan/16 ]

Reopened:
https://jenkins.magnolia-cms.com/job/magnolia-bundle_trunk/lastCompletedBuild/info.magnolia.bundle.test$magnolia-integration-tests/testReport/info.magnolia.integrationtests/MostBasicTest/loginOnAuthorInstanceWithSuperuser/
It looks like the managers need to be started in CoreModule.start() but we cannot due that since the other module which needs to be injected into same command are not started at this point.

Generated at Mon Feb 12 03:52:34 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.