[MAGNOLIA-4103] Channel name should be provided by configuration Created: 14/Feb/12 Updated: 10/Mar/21 Resolved: 10/Mar/21 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | 4.5 |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major |
| Reporter: | Samuel Schmitt | Assignee: | Unassigned |
| Resolution: | Outdated | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoR: |
Empty
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
A nice to have would be to configure the channel name. For the moment it is returned "harcoded" by the channelResolver. For me the resolver should say: yes or not it's resolved and the channel name come from the config, either the name of the node or a name property. Furthermore, channel configuration under Templating Kit > Channels should provide channel names resolved by one given resolver, taking into account that one resolver can resolve more than one channel. Channel config should thus become the place where modules providing their own resolver will write channel names |
| Comments |
| Comment by Federico Grilli [ 21/Mar/12 ] |
|
Tentatively put into 4.5.2 |
| Comment by Jan Haderka [ 30/Mar/12 ] |
|
DeviceChannelResolver provides basic configuration. Functionality of this class allows resolving multiple channels which makes it impossible to use node name as a name of a channel and would also make it complicated to make name of each channel configurable. Similar to TemplateAvailability this class provides implementation that should be suitable for most users. In case of need of more specialized or more configurable resolver this class can and should be replaced with custom implementation. |
| Comment by Antti Hietala [ 10/Apr/12 ] |
|
The problem is that the current channel implementation is not transparent. It is not possible for a user to know which resolver resolves his channels by looking at the configuration. He must look in the source code. Furthermore, the mapping between channels and variations is not transparent either. I can describe this in documentation to mitigate the issue. However, I suggest we fix the root cause:
|
| Comment by Jan Haderka [ 10/Apr/12 ] |
|
Needs further discussion. |
| Comment by Jan Haderka [ 09/Oct/12 ] |
|
Definitively not something that can be changed in the minor release. |