[MAGNOLIA-4108] Dialog opened twice if placeholder is double-clicked Created: 14/Mar/12  Updated: 24/May/12  Resolved: 24/Apr/12

Status: Closed
Project: Magnolia
Component/s: page editor
Affects Version/s: 4.5.1
Fix Version/s: 4.5.3

Type: Bug Priority: Neutral
Reporter: Andreas Weder Assignee: Federico Grilli
Resolution: Won't Fix Votes: 0
Labels: usertestresult
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MAGNOLIA-4112 Placeholder for adding component trig... Closed
is related to MAGNOLIA-4113 Adblocker on Firefox causes edit dial... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

If you double-click inside the dotted area of a component placeholder, the edit dialog is opened twice. This does not happen, if you double-click on the "plus" icon in the component edit bar.

While this may seem like a non-bug, the dotted area did indeed seduce some users during testing to double-click it in order to "start editing" (it's like double-clicking a text to in-line edit it).



 Comments   
Comment by Andreas Weder [ 15/Mar/12 ]

The solution used for handling the click inside the dotted area of a placeholder also causes different issues like this one.

Can we change the way the click is handled?

Comment by Andreas Weder [ 15/Mar/12 ]

Adding a third issue caused by the way we're currently catching the click inside the dotted area of a placeholder.

Comment by Federico Grilli [ 24/Apr/12 ]

It turned out to be not so easy and straightforward to fix this. I tried using clickEvent handler instead of the mouseDown currently used, I tried to catch the doubleClick event and do nothing there, I tried with default event prevention, but all to no avail. And btw, I have seen the same behavior occurring also when clicking on the edit bar plus icon. I thought that opening a window by giving it a name as we do in our mgnlOpenWindow() js function would prevent multiple popups to be displayed but this is not the case (probably because we append a timestamp to the window name, thus making each window a new one). A possible (dubious) solution could involve unregistering the event inside the handler, display the popup (and maybe sleep() 1 or 2 s) and finally register again the event before leaving the handler.

Generated at Mon Feb 12 03:52:43 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.