[MAGNOLIA-4112] Placeholder for adding component triggers Firefox' popup blocker Created: 03/Feb/12  Updated: 10/Mar/21  Resolved: 10/Mar/21

Status: Closed
Project: Magnolia
Component/s: page editor
Affects Version/s: 4.5.1
Fix Version/s: 4.5.x

Type: Bug Priority: Neutral
Reporter: Natascha Desmarais Assignee: Unassigned
Resolution: Won't Fix Votes: 0
Labels: firefox, pageeditor, popupblocker
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

CE 4.5b5
FF 10.0


Attachments: PNG File Bildschirmfoto 2012-03-14 um 18.35.13.png     PNG File Screen shot 2012-02-03 at 4.11.36 PM.png    
Issue Links:
relation
is related to MAGNOLIA-4108 Dialog opened twice if placeholder is... Closed
is related to MAGNOLIA-4113 Adblocker on Firefox causes edit dial... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

When trying to add a component in the base area, the placeholder link triggers Firefox' own popup blocker unless you've allowed popups from localhost generally. The page editor bars - including the add button from the base area - and their popups work as expected with no problem. The problem is the placeholder link.

While it is easy to simply add that exception for popups from localhost (or whatever site this version of magnolia is running on), it might not be so easy to achieve that in some clients' environment where a single user cannot allow these due to company policies. If there is a workaround for making this work in FF without having to add an exception to the rules, it would be most preferable.

Tested this also in Safari 5.1.2 and Chrome 16.0.912.77 on Mac OS X and it worked normally. Seems like Firefox is the only troublemaker this time (maybe check IE 9 as well)



 Comments   
Comment by Espen Jervidalo [ 16/Feb/12 ]

This is fixed in beta6, where we reintroduced the add-Button and removed the onClick function from the placeholder. I leave this open, as we are probably going to add the onclick back.

Comment by Espen Jervidalo [ 02/Mar/12 ]

This is still the case on the placeholder, after reintroducing click handler. But there is now also the possibility to use the icon. so marking it as "won't fix".

Comment by Andreas Weder [ 15/Mar/12 ]

I'm attaching another screenshot from 4.5.1 and FF 10.0.2.

Comment by Andreas Weder [ 15/Mar/12 ]

I think we should have another look at this nevertheless.

I've linked two other issues, which relate to this behavior, which seem to be also caused by how we implemented this click. Is there an alternative, which gets rid of all of them at once?

Generated at Mon Feb 12 03:52:46 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.