[MAGNOLIA-4119] page editor: simplify create optional area Created: 28/Feb/12  Updated: 22/Mar/12  Resolved: 02/Mar/12

Status: Closed
Project: Magnolia
Component/s: page editor
Affects Version/s: 4.5
Fix Version/s: 5.0

Type: Bug Priority: Neutral
Reporter: Espen Jervidalo Assignee: Espen Jervidalo
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File templating-editor-scrum1061.patch    
Template:
Patch included:
Yes
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Remove the edit-Button from the area bar when the area has not been created.

The current implementation forces you to create an optional area by pressing "+" on the area bar, wait for the page to reload and then edit or add components by calling the according actions.
This should be simplified so that by creating an optional area, after the page reloads the dialog should popup for the next action.
In cases where you can edit the area (e.g. title) this dialog should be opened.
Otherwise the dialog to add components should be opened.



 Comments   
Comment by Espen Jervidalo [ 28/Feb/12 ]

I decided to use a cookie for the implementation.
Using request parameters caused different problems and would have ended up changing legacy javascript calls to remove the parameter again.
Serverside implementation would also have affected more code changes and considering the short time before release I decided against it.

One problem with the current implementation is that the popup-blocker might prevent the dialog from opening. This could only be solved by a serverside implementation I guess.

Comment by Philipp Bärfuss [ 29/Feb/12 ]

I don't think it should work like that. It should open the dialog directly, but if it doesn't work then we keep it as is.

Comment by Espen Jervidalo [ 02/Mar/12 ]

Patch will not be applied.

Generated at Mon Feb 12 03:52:50 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.