[MAGNOLIA-4127] Inheritance (Area): Things not to forget about inheritance Created: 19/Oct/11  Updated: 27/Nov/13  Resolved: 22/Mar/12

Status: Closed
Project: Magnolia
Component/s: templating
Affects Version/s: 4.5
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Christian Ringele Assignee: Tobias Mattsson
Resolution: Outdated Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MAGNOLIA-4084 templating inheritance: open question... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

In this issue, I note the things about inheritance which should not get forgotten.
By this I don't mean they shouldn't be forgotten to implement for first release, but not being forgotten as use cases and general behavior for possible future implementations. So in this state it might be important to know about theses cases.

1. Detecting the parent page of the area content should be using the model hierarchy and not the physical node hierarchy:
Now that an area has a definition, it can be rendered from any other template script -> getting to node and render it.
To collect the content from the parent pages, the parent page of the area should be the parent by the model hierarchy.
Otherwise it will always inherit the content from the physical structure and not from the rendered page and its parent pages.

2. STK scope prototype&concrete template.
What should happen, if the prototype is not defining a inheritance on an area, but a concrete template does (for example an article)?
When defined on the prototype its clear, every page inherits the content form the parents in this area.
When defined only on an article does that mean:

  • The article inherits its content down to all subpages?
  • Or the article gets all the content from the pages above? -> all subpages of an article being not a article wouldn't have inherited content.
    Now how its defined in stk: you tell a element (in extras for example) inherit to subpages. Marking only on article template a complete area to be inherited, I would expect the same behavior -> inherit all down.


 Comments   
Comment by Philipp Bärfuss [ 22/Dec/11 ]

Can you quickly verify/discuss that?

Comment by Tobias Mattsson [ 23/Dec/11 ]

Please see reference http://wiki.magnolia-cms.com/display/DEV/Templating+-+Proposal#Templating-Proposal-Inheritance

Generated at Mon Feb 12 03:52:55 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.