[MAGNOLIA-4128] Enhance ComponentTestUtils to also support GuiceComponentProvider Created: 17/Jun/11  Updated: 04/Nov/15  Resolved: 04/Nov/15

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: None
Fix Version/s: 4.5.x

Type: Improvement Priority: Neutral
Reporter: Daniel Lipp Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

Right now ComponentTestUtils hardcoded relies on MockComponentProvider. As soon as you e.g. want to use a GuiceComponentProvider you cannot use it any longer.

Proposal how to do that (by tmattsson):
@RunWith(MagnoliaPicoRunner.class)
public class ExampleGuiceTest {

@ConfigureComponents
public void configureComponents(GuiceComponentProvider provider)

{ ModuleRegistry moduleRegistry = mock(ModuleRegistry.class); when(moduleRegistry.getModuleNames()).thenReturn(new HashSet<String>()); provider.registerInstance(ModuleRegistry.class, moduleRegistry); }

@Inject
private ModuleRegistry moduleRegistry;

@Test
public void testSomething()

{ assertTrue(moduleRegistry.getModuleNames().isEmpty()); }

}



 Comments   
Comment by Daniel Lipp [ 11/Jul/11 ]

updated description as we gave up Pico in favor of Guice

Comment by Tobias Mattsson [ 29/Aug/11 ]

In my opinion ComponentsTestUtil should be removed or at least deprecated.

Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 03:52:55 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.