[MAGNOLIA-4129] Remove duplicated methods from SecurityUtil Created: 19/Dec/11  Updated: 23/Jun/14  Resolved: 13/Jul/12

Status: Closed
Project: Magnolia
Component/s: security
Affects Version/s: 4.5
Fix Version/s: 4.5.4

Type: Bug Priority: Neutral
Reporter: Jan Haderka Assignee: Robert Šiška
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
duplicate
is duplicated by MAGNOLIA-4345 use digester to generate signatures i... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Currently there is bunch of methods duplicated between info.magnolia.cms.security.SecurityUtil and info.magnolia.cms.security.Digester. Duplicates should be removed. It might be also wise to merge 2 classes in one named SecurityUtil to be more obvious.
When removing duplicates, the code to generate MD5 in exchange-simple and exchange-transactional should be also replaced with that of the util class.



 Comments   
Comment by Robert Šiška [ 04/Jun/12 ]

Digester class should use methods from SecurityUtil.

Comment by Jan Haderka [ 26/Jun/12 ]

There's really no point keeping simple ByteArrayOutputStream md5 as class level variable in ReceiveFilter and ResourceCollector, is there?

Generated at Mon Feb 12 03:52:56 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.