[MAGNOLIA-4132] Creating a bypass of type info.magnolia.voting.voters.URIPatternVoter makes installation un-usable Created: 17/Mar/12  Updated: 02/Jul/12  Resolved: 20/Mar/12

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 4.4.6, 4.5.1
Fix Version/s: 4.4.7, 4.5.2

Type: Bug Priority: Critical
Reporter: Kimmo Björnsson Assignee: Tobias Mattsson
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

It's just to create a bypass of type URIPatternVoter and all requests renders this error. This is a blocking bug for us since much of our application design relies on this.

It was introduced in 4.4.6.

java.lang.NullPointerException
	info.magnolia.voting.voters.URIPatternVoter.boolVote(URIPatternVoter.java:63)
	info.magnolia.voting.voters.AbstractBoolVoter.vote(AbstractBoolVoter.java:63)
	info.magnolia.voting.DefaultVoting.vote(DefaultVoting.java:57)
	info.magnolia.cms.filters.AbstractMgnlFilter.bypasses(AbstractMgnlFilter.java:127)
	info.magnolia.cms.filters.AbstractMgnlFilter.matches(AbstractMgnlFilter.java:98)
	info.magnolia.cms.filters.SafeDestroyMgnlFilterWrapper.matches(SafeDestroyMgnlFilterWrapper.java:100)
	info.magnolia.cms.filters.MgnlFilterDispatcher.doDispatch(MgnlFilterDispatcher.java:66)
	info.magnolia.cms.filters.MgnlMainFilter.doFilter(MgnlMainFilter.java:108)
	info.magnolia.cms.filters.MgnlMainFilter.doFilter(MgnlMainFilter.java:94)



 Comments   
Comment by Ondrej Chytil [ 20/Mar/12 ]

Hi Kimmo,

I'm unable to reproduce this one. Can you please provide us exact steps to run into this issue?

Comment by Tobias Mattsson [ 20/Mar/12 ]

When used as a bypass for the whole filter chain it indeed renders the installation unusable if the pattern isn't set.

Comment by Tobias Mattsson [ 20/Mar/12 ]

Changed the voter to vote false instead of failing with an NPE when a pattern isn't set.

Generated at Mon Feb 12 03:52:58 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.