[MAGNOLIA-4134] Method inPublicMode() in ModeDependentRenderExceptionHandler is never called Created: 19/Mar/12 Updated: 16/May/17 Resolved: 07/Apr/17 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | rendering |
| Affects Version/s: | 4.5, 4.5.1 |
| Fix Version/s: | 5.4.12, 5.5.4 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Tobias Mattsson | Assignee: | Federico Grilli |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||
| Sprint: | Basel 88, Basel 90 | ||||||||||||||||||||||||||||
| Story Points: | 2 | ||||||||||||||||||||||||||||
| Description |
|
The method inPublicMode() in ModeDependentRenderExceptionHandler is never called and ModeDependentTemplateExceptionHandler should not be deprecated because it's a key part of how the mechanism works. When a freemarker template fails this is what happens: Freemarker logs the exception always |
| Comments |
| Comment by Espen Jervidalo [ 27/Mar/17 ] |
|
had There are around 5 related and completely bogus tickets around this topic. I tried to summarize the mess here: https://jira.magnolia-cms.com/browse/MAGNOLIA-6692?focusedCommentId=140515&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-140515 Conclusion:
So, this one should not have been blocked, but verified properly. |