page editor (MAGNOLIA-4164)

[MAGNOLIA-4237] page editor: bar designs: bars should not inject their div design Created: 15/Jul/11  Updated: 22/Mar/12  Resolved: 22/Dec/11

Status: Closed
Project: Magnolia
Component/s: page editor
Affects Version/s: None
Fix Version/s: 4.5

Type: Sub-task Priority: Neutral
Reporter: Christian Ringele Assignee: Philipp Bärfuss
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MAGNOLIA-4238 page editor: cms:edit should allow a ... Closed
relation
Template:

 Description   

Magnolia bars are injecting at the moment their div style design directly in the output.
In my opinion all bars should just define a div class.

By that you could design the bars as you like within the page's/site's css.
See http://wiki.magnolia-cms.com/display/MAGNOLIA5/Templating+-+Proposal?focusedCommentId=50792741#comment-50792741

Probably the page editor should inject a css for the bars which do not overwrite the class values, if already defined within the page's css.



 Comments   
Comment by Christian Ringele [ 15/Jul/11 ]

The linked task SCRUM-298 and its commits show this weakness.
The h3 have a padding-top.
So the bars appear closer to the element above instead its own component.

Generated at Mon Feb 12 03:53:54 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.