[MAGNOLIA-4370] GuiceComponentProvider should not test for explicit bindings Created: 12/Apr/12  Updated: 10/Mar/21  Resolved: 10/Mar/21

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 4.5, 4.5.1, 4.5.2
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Tobias Mattsson Assignee: Unassigned
Resolution: Outdated Votes: 0
Labels: ioc
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

GuiceComponentProvider tests for explicit bindings in both getComponent() and getProvider(). Since we don't have Guice set to require explicit bindings and since we're using just-in-time creation of objects it makes no sense to do this check.

For instance, a class A annotated with @Singleton can be injected into another class B that requires it. But it's not possible to ask for the instance of class A directly on GuiceComponentProvider.


Generated at Mon Feb 12 03:55:08 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.