[MAGNOLIA-4380] magnolia-empty-webapp should provide dependency on magnolia-templating-jsp and compatibility jars Created: 19/Apr/12 Updated: 28/May/12 Resolved: 25/May/12 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | build |
| Affects Version/s: | None |
| Fix Version/s: | 4.5.3 |
| Type: | Task | Priority: | Neutral |
| Reporter: | Federico Grilli | Assignee: | Milan Divilek |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Template: |
|
||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||
| Task DoR: |
Empty
|
||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||
| Description |
|
As both CE and EE webapps depend on m-empty-webapp and as Magnolia aims at providing JSP support out of the box, it makes sense to add m-templating-jsp dependency to the m-empty-webapp module. We also want to provide compatibility jars directly in the magnolia-empty-webapp rather than provide them as an add-on or as separate downloads. Furthermore, m-templating-samples should use scope provided so that the add-ons folder in the bundles does not contain a useless duplicate of m-templating-jsp jar |
| Comments |
| Comment by Ondrej Chytil [ 21/May/12 ] |
|
Also magnolia-templating-compatibility, magnolia-templating-compatibility-taglib-cms and magnolia-templating-compatibility-taglib-utility should be part of bundled webapp. |
| Comment by Jan Haderka [ 23/May/12 ] |
|
Change priority to critical to make sure this is solved before release. Reset to neutral once done. |
| Comment by Jan Haderka [ 24/May/12 ] |
|
I thought we agreed to only add jsp support to webapp, but keep all compatibility modules in add ons. Seems like there is lot of confusion and moving back and forth. Pls discuss before making any more changes or closing this issue. |
| Comment by Ondrej Chytil [ 24/May/12 ] |
|
We discussed it and both (you Jan and me) agreed that it should go all in webapp if I remember correctly - since there are some support tickets where the issue basicly is just that taglib is not in webapp. |
| Comment by Federico Grilli [ 24/May/12 ] |
|
After having briefly discussed this with Ondrej I thought that basically all compatibility deps, that is magnolia-templating-compatibility, magnolia-templating-compatibility-taglib-cms and magnolia-templating-compatibility-taglib-utility, should go straight into the m-empty-webapp and no longer as add-ons (it's also worth mentioning that so far only magnolia-templating-compatibility ended up in add-ons, whilst the other two compatibility libs were not bundled anywhere). |