[MAGNOLIA-4387] Navigation title of other languages is not used Created: 25/Apr/12  Updated: 25/Jun/12  Resolved: 27/Apr/12

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 4.5.2
Fix Version/s: 4.5.3

Type: Bug Priority: Major
Reporter: Ondrej Chytil Assignee: Federico Grilli
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MAGNOLIA-4388 i18n wrapper doesn't return value for... Closed
is related to MAGNOLIA-4436 Breadcrumb ignores localized navigati... Closed
is related to MGNLSTK-978 Multilanguage Support for Overviews ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Steps to reproduce:

  • open demo-project page
  • switch to german language
  • fill headline and navigation title in page properties
    -> headline is used in navigation
  • switch to english
  • fill navigation title
  • switch back to german
    -> correct german title is used


 Comments   
Comment by Federico Grilli [ 26/Apr/12 ]

Solved implicitly by MAGNOLIA-4388

Comment by Zdenek Skodik [ 27/Apr/12 ]

MAGNOLIA-4388 sounds good, however it doesn't fix this bug, which also affects breadcrumb by the way.

Comment by Federico Grilli [ 27/Apr/12 ]

Are you sure? I tested this particular use case with the fix I applied with MAGNOLIA-4388 and it worked, breadcrumb too. Actually, there's a different issue I just found out but it has to do with node wrapping (i18n node wrapping is lost in one particular case). I will open a specific jira for that.

Comment by Zdenek Skodik [ 27/Apr/12 ]

Yes, I'm sure that the fix has been taken into account. It works on a single level, but the wrapping doesn't work down in the hierarchy. Let say you have /demo-project/about/history-de but if you render its child history-de turns back to history and only the child gets localized /demo-project/about/history/child-de. Perhaps this is the particular case you have in mind.

Comment by Federico Grilli [ 27/Apr/12 ]

Yep, that's exactly the case I have in mind.

Comment by Federico Grilli [ 27/Apr/12 ]

To sum up what Zdenek and I already said in the previous comments: fixing MAGNOLIA-4388 actually resulted in the problem disappearing on root level, i.e. on /demo-project page the navigation titles were correctly shown localized. However, the issue popped up again down in the hierarchy, i.e. at /demo-project/about the navigation titles were again in the default language. It turned out that I18nNode wrapping was lost here info.magnolia.module.templatingkit.templates.category.TemplateCategoryUtil.findParentWithTemplateCategory(Content, String) line #154 where current.getParent() current being "I18nWrapped" would return an unwrapped node, simply because I18nNodeWrapper did not override the getParent() method.

Generated at Mon Feb 12 03:55:17 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.