[MAGNOLIA-4410] IE7: dialogs are not closed on save Created: 14/May/12 Updated: 19/Dec/16 Resolved: 12/Apr/16 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | admininterface |
| Affects Version/s: | 4.4.6, 4.5.2 |
| Fix Version/s: | 4.5.x |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Natascha Desmarais | Assignee: | Unassigned |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | browser_issue, dialogs, ie7, savehandler | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Tested on EE v4.4.6 as well as v4.5.2 |
||
| Attachments: |
|
||||
| Issue Links: |
|
||||
| Template: |
|
||||
| Acceptance criteria: |
Empty
|
||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||
| Date of First Response: | |||||
| Description |
|
In InternetExplorer 7 the dialogs don't close on saving. Instead it redirects the dialog to a white page displaying "Move the selected component/paragraph above this one". One can close this dialog and manually refresh the page and see the change however. Adding a node data jsExecutedAfterSaving with value opener.document.location.reload();window.opener=self;window.close(); to a random dialog seems to fix this problem for IE7 and this specific dialog. Tested this with IE8 as well, but it behaves normally and closes the dialogs on its own without the extra JS. The js error message for IE7 not closing is: |
| Comments |
| Comment by Natascha Desmarais [ 14/May/12 ] |
|
Attached two files: Screenshot from a 4.4.6 instance with the error code displayed and a smaller screenshot from the current demo site (running v4.5.2) showing the same problem in IE7 |
| Comment by Federico Grilli [ 14/May/12 ] |
|
A little debugging on IE7 with IETester showed that the actual message is "'window.opener.document' is null or not an object" which is happening at /magnolia-module-admininterface/src/main/resources/mgnl-resources/admin-js/dialogs/dialogs.js in the mgnlDialogReloadOpener() function. It also looks like this is an annoying known bug of IE7 http://forums.asp.net/t/1156782.aspx/1 but the window.opener=self workaround seems to do the trick whichI would therefore try to introduce in our js, something like if(window.opener.document == null) { window = self; } |
| Comment by Federico Grilli [ 14/May/12 ] |
|
And just for the records and to prove that it's no Magnolia bug, IE7 even screws up this w3school example with the same issue |
| Comment by Antti Hietala [ 12/Apr/16 ] |
|
On January 12, 2016, Microsoft ended support for Internet Explorer versions 8, 9 and 10. Following Microsoft's decision, Magnolia ends support for IE 8, 9 and 10. This means we will not fix bugs related to these end-of-life browsers. IE 8, 9 and 10 are no longer supported on any Magnolia version.
I am closing this ticket. Thanks for taking the time to raise the issue. |