[MAGNOLIA-4412] default template variation resolvers should consider the extension Created: 15/May/12  Updated: 17/Jul/13  Resolved: 25/May/12

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 4.5.2
Fix Version/s: 4.5.3

Type: Bug Priority: Critical
Reporter: Philipp Bärfuss Assignee: Milan Divilek
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing DOCU-304 Documentation for subtemplates being ... Closed
relation
is related to MGNLSTK-1210 default site variation resolvers shou... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

In older versions we supported so called sub templates (selected based on file name extension). In 4.5 we have introduced the more powerful template variations but our default implementation does only consider the channel.

But it should use the following lookup for template variation names

  1. channel-extension
  2. extension
  3. channel

Then instead of the two subclasses we should ship one which combines them: RenderableVariationResolver.



 Comments   
Comment by Philipp Bärfuss [ 25/May/12 ]

The class should be named DefaultRenderableVariationResolver. Otherwise it looks OK.

Comment by Robert Šiška [ 08/Jul/13 ]

Resolving from extensions only work for template variations.

Site variations should be toggled this way as well: MAGNOLIA-5166

Comment by Roman Kovařík [ 17/Jul/13 ]

Commits:
https://git.magnolia-cms.com/gitweb/?p=magnolia_main.git&a=search&h=HEAD&st=commit&s=MAGNOLIA-4412

Generated at Mon Feb 12 03:55:32 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.