[MAGNOLIA-4473] Restore command does not restore the selected version Created: 11/Jul/12 Updated: 20/Feb/13 Resolved: 04/Dec/12 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | admininterface |
| Affects Version/s: | 4.5.3 |
| Fix Version/s: | 4.5.7 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Antti Hietala | Assignee: | Milan Divilek |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||
| Issue Links: |
|
||||||||||||||||
| Template: |
|
||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||
| Date of First Response: | |||||||||||||||||
| Description |
|
The Restore command does not restore the selected version. It sometimes restores the "latest" version instead. The Restore button is only enabled when you select a list item but the command does not act on the selected item. To reproduce, first build a version history:
Then restore the first version:
Issue: The system displays a message "Successfully restored latest version", see message.png Restore again:
The problem is that the system responds differently to the same user action. First it versions the latest version (Wednesday), then the user-selected version (Monday). |
| Comments |
| Comment by Milan Divilek [ 03/Dec/12 ] |
|
When I tried reproduce the issue I figured out that the correct version is restored, but wrong comment is used. The version which is create during restore isn't restored version but it's saved current state. -> So comment should be "Automatically created version prior restoration". This was fixed in Message "Successfully restored latest version" is wrong. This message is used for restoring any version. Correct message should be "Version was successfully restored.". -> Fixed in this ticket There is still another use case when incorrect version comment is used: When you restore version which contains version comment then the comment is also restored. Then if you create new version which has blank version comment then the restored version comment is used instead the blank one. -> Fixed in this ticket |
| Comment by Milan Divilek [ 04/Dec/12 ] |
|
Port to 5.0 can't be done right now. Because 5.0 doesn't support metadata. This issue should be ported after refactoring VersionCommand. |