[MAGNOLIA-4481] Core: LinkUtil should be refactored for use with Node type Created: 30/Jun/11  Updated: 11/Feb/13  Resolved: 02/Nov/12

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: None
Fix Version/s: 5.0

Type: Bug Priority: Neutral
Reporter: Christian Ringele Assignee: Ondrej Chytil
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File nodeBasedLink-patch-2.txt    
Issue Links:
causality
is causing MAGNOLIA-4433 Templating samples don't render images Closed
relation
is related to MAGNOLIA-4444 TemplatingFunctions.link* methods pro... Closed
Template:
Patch included:
Yes
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Comments   
Comment by Federico Grilli [ 12/Oct/11 ]

This patch provides most of the node based implementations for Link, LinkUtil, LinkFactory and friends. Old content based impl delegates to the new node based one. Manual tests with the samples module seem to show that the new impl works (also with links created within fck editor). However, since there currently are several tests failing due to partially implemented mocks and since the priority has now shifted to other more urgent tasks work on this issue will be temporarily stopped and resumed at a later time.

Comment by Federico Grilli [ 09/Nov/11 ]

upgraded patch after applying old version to latest trunk.

Comment by Federico Grilli [ 09/Nov/11 ]

Stopping progress on this ticket as other tasks have taken higher priority now. Also, as there was not enough time to come up with a clean solution for handling binary node data as jcr properties, this patch will need to be reworked anyways.

Comment by Philipp Bärfuss [ 22/Dec/11 ]

the link API wont get re-factored in 4.5

Comment by Jan Haderka [ 15/Jun/12 ]

In the future, make sure all changes are rolled back to a ticket that is being resolved as won't-fix (or similar resolutions resulting in rejection of the ticket).

Comment by Jan Haderka [ 19/Jul/12 ]

LinkUtil needs to be refactored to use Node API instead of Content API. The fact that it didin't happen for 4.5 doesn't make it valid to close the issue.

Generated at Mon Feb 12 03:56:12 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.