[MAGNOLIA-4510] Render editBar for flash component Created: 13/Jun/12 Updated: 10/Oct/13 Resolved: 26/Sep/12 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | page editor |
| Affects Version/s: | 4.5 |
| Fix Version/s: | 4.5.5 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Zdenek Skodik | Assignee: | Milan Divilek |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||
| Description |
|
PageEditor is not able to cope with it at the moment so that one needs to add a <div cms:edit> explicitly in order to workaround it. |
| Comments |
| Comment by Espen Jervidalo [ 14/Jun/12 ] |
|
The EditBar of the Component is being injected into the object element: <!-- cms:component --> As a workaround you can wrap the object into a <div> or explicitly place the editbar using the <div cms:edit=""> marker. |
| Comment by Natascha Desmarais [ 09/Aug/12 ] |
|
Same thing happens in the stkHTML component if you use <embed> for example. This is the sample code [1] that was used for the screenshot example: <embed width="420" height="345" src="http://www.youtube.com/v/XGSy3_Czz8k" type="application/x-shockwave-flash"> </embed> [1] from w3c schools |
| Comment by Jan Haderka [ 24/Aug/12 ] |
|
Test? |
| Comment by Jan Haderka [ 18/Sep/12 ] |
|
Are we sure that the hasTagName() is not case sensitive and that it will always stay that way? |
| Comment by Milan Divilek [ 26/Sep/12 ] |
Method hasTagName() is case sensitive, but in depends on w3 specification Element tagName must return element names converted to ASCII uppercase. http://www.w3.org/TR/DOM-Level-2-HTML/html.html#ID-822762427 |