[MAGNOLIA-4520] farFutureCaching and Resource files with dot in name cannot be found Created: 28/Aug/12 Updated: 22/May/15 Resolved: 28/Feb/14 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | cache |
| Affects Version/s: | 4.5.3 |
| Fix Version/s: | 4.5.17 |
| Type: | Bug | Priority: | Major |
| Reporter: | Stef te Winkel | Assignee: | Robert Šiška |
| Resolution: | Fixed | Votes: | 4 |
| Labels: | maintenance | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||||||||||||||||||||||
| Release notes required: |
Yes
|
||||||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||||||
| Description |
|
As a result of the thread in When filenames in the resource directory contain dots, and the farFuturecaching is set to true, the files cannot be found. The regular expression in /modules/cache/virtualURIMapping/tildeCacheRessources/fromURI (\.*)\.(\d{4}-(?:\d{2}-){5}\d{3})\.cache\.(css|js)
doesn't seem to handle occurences of dots in the filename itself. (not all dots get replaced by a tilde?) |
| Comments |
| Comment by Christian Ringele [ 19/Apr/13 ] |
|
it is a very common pattern in JS files, to add dots into the file name. |
| Comment by Edgar Vonk [ 02/Jun/13 ] |
|
Hi, is there any update on this issue? We run into this issue for every Magnolia project that we do. It is a lot of work to keep telling all our JavaScript developers to stop using dots in JavaScript file names.. |
| Comment by Marcel Stör [ 01/Nov/13 ] |
|
Just came across this bug looking for "Magnolia farFutureCaching". We cannot depend on all JS files not having dots in their file names as it's such a common pattern. Hence, this bug renders far future caching useless for us. |
| Comment by Sven Damm [ 19/Feb/14 ] |
|
Please please please fix this! I have to rename dozens of css and javascript files and update their references for every new project. What a PITA |
| Comment by Robert Šiška [ 28/Feb/14 ] |
|
Closing with quick fix - mapping process needs to be reconsidered. |
| Comment by Roman Kovařík [ 28/Feb/14 ] |
|
Causes failure of bundles: |
| Comment by Roman Kovařík [ 13/Mar/14 ] |
|
This fix was reverted from 5.2.x and master due to |