[MAGNOLIA-4520] farFutureCaching and Resource files with dot in name cannot be found Created: 28/Aug/12  Updated: 22/May/15  Resolved: 28/Feb/14

Status: Closed
Project: Magnolia
Component/s: cache
Affects Version/s: 4.5.3
Fix Version/s: 4.5.17

Type: Bug Priority: Major
Reporter: Stef te Winkel Assignee: Robert Šiška
Resolution: Fixed Votes: 4
Labels: maintenance
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Cloners
is cloned by MAGNOLIA-5712 farFutureCaching and Resource files w... Closed
Relates
relates to MGNLRES-152 Generate links to resources, and use ... Closed
causality
is causing MAGNOLIA-5711 Dot before and after selector causes NPE Closed
relation
is related to MAGNOLIA-4207 Fix the cache ressources issue. Closed
is related to MGNLSTK-786 far future cache: use a more resource... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Release notes required:
Yes
Date of First Response:

 Description   

As a result of the thread in
http://forum.magnolia-cms.com/forum/thread.html?threadId=6eadb707-e2ee-4fc8-98c2-b931cd85b84b&page=1
this issue:

When filenames in the resource directory contain dots, and the farFuturecaching is set to true, the files cannot be found.
(for example jquery-1.7.1.js, core.module.js or jsscript.min.js)

The regular expression in /modules/cache/virtualURIMapping/tildeCacheRessources/fromURI

(\.*)\.(\d{4}-(?:\d{2}-){5}\d{3})\.cache\.(css|js)

doesn't seem to handle occurences of dots in the filename itself.

(not all dots get replaced by a tilde?)



 Comments   
Comment by Christian Ringele [ 19/Apr/13 ]

it is a very common pattern in JS files, to add dots into the file name.
So on all these files it won't work -> increasing priority.

Comment by Edgar Vonk [ 02/Jun/13 ]

Hi, is there any update on this issue? We run into this issue for every Magnolia project that we do. It is a lot of work to keep telling all our JavaScript developers to stop using dots in JavaScript file names..

Comment by Marcel Stör [ 01/Nov/13 ]

Just came across this bug looking for "Magnolia farFutureCaching". We cannot depend on all JS files not having dots in their file names as it's such a common pattern. Hence, this bug renders far future caching useless for us.
It's a major bug (and annoyance) that's been open for more than a year. Could we please have this fixed any time soon?

Comment by Sven Damm [ 19/Feb/14 ]

Please please please fix this! I have to rename dozens of css and javascript files and update their references for every new project. What a PITA

Comment by Robert Šiška [ 28/Feb/14 ]

Closing with quick fix - mapping process needs to be reconsidered.

Comment by Roman Kovařík [ 28/Feb/14 ]

Causes failure of bundles:
http://hudson.magnolia-cms.com/view/CE_bundles/

Comment by Roman Kovařík [ 13/Mar/14 ]

This fix was reverted from 5.2.x and master due to MAGNOLIA-5711. New ticket for Magnolia 5 (MAGNOLIA-5712) created.

Generated at Mon Feb 12 03:56:34 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.