[MAGNOLIA-4542] Upgrade JR to 2.4.3 Created: 20/Sep/12  Updated: 11/Feb/13  Resolved: 15/Nov/12

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 4.5.4, 5.0
Fix Version/s: 4.5.7, 5.0

Type: Task Priority: Major
Reporter: Daniel Lipp Assignee: Federico Grilli
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLMIGRATION-158 Exclude duplicated entry for antlr.jar Closed
is related to MAGNOLIA-4398 Ugrade JR to 2.4.1 Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

see release notes for details



 Comments   
Comment by Jan Haderka [ 21/Sep/12 ]

looking at the release notes
[JCR-3377] - DataStore Temp-Files will not be deleted as side effect of JCR-3318
[JCR-3393] - InternalVersionManagerBase.calculateCheckinVersionName may fail with NPE on broken versioning persistence

looks like worth the update.

Comment by Jan Haderka [ 16/Oct/12 ]

Did you also check that created bundle doesn't have any duplicated libraries and that there were no changes in versions of libs that are being pulled by JR into bundle?
Thx.

Comment by Federico Grilli [ 16/Oct/12 ]

Jan, good point: reopening until that check is done.

Comment by Federico Grilli [ 30/Oct/12 ]

All looks fine. The only duplicated entry is antlr.jar 3.4 and 2.7.7 the latter pulled in by stringtemplate.jar. antlr is brought in by magnolia-4-5-migration module.

Comment by Jan Haderka [ 09/Nov/12 ]

Why is jr version specified in empty webapp pom? All versions in that pom should be specified in parent (ce bundle in this case) similarly to what it was before when empty webapp was part of main project.

Comment by Jan Haderka [ 15/Nov/12 ]

both empty and bundled web apps now contains duplicated jars

-rw-r--r--    1 had  staff   1.5M Aug 16 13:37 bcprov-jdk14-1.38.jar
-rw-r--r--    1 had  staff   1.5M Aug 16 13:37 bcprov-jdk14-138.jar
-rw-r--r--    1 had  staff   1.8M Aug  3 11:35 bcprov-jdk16-1.46.jar

... there's more bouncy castle duplicates then just those above. Also ant jar is duplicated in bundled web app. The only duplicates that are allowed are icepush which as Sasha explained elsewhere is not a duplicate, but different artifact w/ same name and antlr which as Robert found out has defined such dependency internally.

Comment by Federico Grilli [ 15/Nov/12 ]

Okay but this hasn't to do with upgrade to JR 2.4.3. This poor guy is blamed for everything by now Those duplicated deps must be around well before upgrading to this bugfix version of JR. As far as I could see the bcprov deps are brought in by both core and by itext via flying-saucer-pdf -> magnolia-module-page-export. Also I am not a BC expert and really don't know if they are actually duplicated (are bcprov-jdk14-1.38 and bcprov-jdk14-138 the same lib or different?) Same goes for ant 1.7.0 which is pulled in by magnolia-module-page-export via htmlcleaner. I'll create separate Jira issues for those.

Generated at Mon Feb 12 03:56:47 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.