[MAGNOLIA-4542] Upgrade JR to 2.4.3 Created: 20/Sep/12 Updated: 11/Feb/13 Resolved: 15/Nov/12 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | 4.5.4, 5.0 |
| Fix Version/s: | 4.5.7, 5.0 |
| Type: | Task | Priority: | Major |
| Reporter: | Daniel Lipp | Assignee: | Federico Grilli |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoR: |
Empty
|
||||||||||||
| Date of First Response: | |||||||||||||
| Description |
|
see release notes for details |
| Comments |
| Comment by Jan Haderka [ 21/Sep/12 ] |
|
looking at the release notes looks like worth the update. |
| Comment by Jan Haderka [ 16/Oct/12 ] |
|
Did you also check that created bundle doesn't have any duplicated libraries and that there were no changes in versions of libs that are being pulled by JR into bundle? |
| Comment by Federico Grilli [ 16/Oct/12 ] |
|
Jan, good point: reopening until that check is done. |
| Comment by Federico Grilli [ 30/Oct/12 ] |
|
All looks fine. The only duplicated entry is antlr.jar 3.4 and 2.7.7 the latter pulled in by stringtemplate.jar. antlr is brought in by magnolia-4-5-migration module. |
| Comment by Jan Haderka [ 09/Nov/12 ] |
|
Why is jr version specified in empty webapp pom? All versions in that pom should be specified in parent (ce bundle in this case) similarly to what it was before when empty webapp was part of main project. |
| Comment by Jan Haderka [ 15/Nov/12 ] |
|
both empty and bundled web apps now contains duplicated jars -rw-r--r-- 1 had staff 1.5M Aug 16 13:37 bcprov-jdk14-1.38.jar -rw-r--r-- 1 had staff 1.5M Aug 16 13:37 bcprov-jdk14-138.jar -rw-r--r-- 1 had staff 1.8M Aug 3 11:35 bcprov-jdk16-1.46.jar ... there's more bouncy castle duplicates then just those above. Also ant jar is duplicated in bundled web app. The only duplicates that are allowed are icepush which as Sasha explained elsewhere is not a duplicate, but different artifact w/ same name and antlr which as Robert found out has defined such dependency internally. |
| Comment by Federico Grilli [ 15/Nov/12 ] |
|
Okay but this hasn't to do with upgrade to JR 2.4.3. This poor guy is blamed for everything by now |