[MAGNOLIA-4553] Current state of areas was always activated instead of versioned one due to incorrect evaluation of node super types. Created: 28/Sep/12  Updated: 04/Oct/12  Resolved: 04/Oct/12

Status: Closed
Project: Magnolia
Component/s: activation, admininterface, core, workflow
Affects Version/s: 4.5.4
Fix Version/s: 4.5.5

Type: Bug Priority: Blocker
Reporter: Frank Sommer Assignee: Milan Divilek
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLSYNC-13 Content is synchronized even when is ... Closed
relation
is related to MAGNOLIA-4562 Write integration test for workflow a... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Cases:

  • info.magnolia.jcr.util.NodeUtil.isNodeType(Node, String). Here we are doing for frozenNode simple equals for types.
  • info.magnolia.cms.util.Rule.isAllowed(String) should not be used. Because it's also doing only simple equals but not consider subtypes. We should used info.magnolia.cms.util.Rule.isAllowed(Node) instead.

This has side effect on ActivationCommand which activates always the current state not the versioned state.

This could be reproduced on demoauthor instance.
Here the steps to reproduce:

  1. Activate demo-project page in AdminCentral
  2. Change on the first carousel item the headline
  3. Proceed your activation in the inbox
  4. Look at http://demopublic.magnolia-cms.com/demo-project.html and you will see your change in the caroussel (this is the bug, you should see the version of step 1.

It is worth noting that the issue does not seem to concern content at page level. I.e. I tried to reproduce it with the title of the /demo-project/about page and there the behavior looks correct.

  1. Change the title to "About Foo"
  2. Activate changes (but do not proceed)
  3. Change again the title into "About Baz"
  4. Proceed with pending activation

Result: as expected the published page has title set at step 1.


Generated at Mon Feb 12 03:56:53 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.