[MAGNOLIA-4639] Link API update Created: 02/Nov/12  Updated: 15/Jun/15  Resolved: 03/Dec/12

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 5.0
Fix Version/s: 5.0

Type: Improvement Priority: Neutral
Reporter: Ondrej Chytil Assignee: Ondrej Chytil
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MAGNOLIA-6186 Remove deprecated Content API from UR... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

There is still some code refactoring needed in Link related classes (Link, LinkUtil...).

  • Code is not yet 100% converted to use Node/Property API.
  • Javadoc needs to be updated for deprecated methods.
  • Tests are still using expectation to old API.
  • Also few improvements of methods logic while handling with old API cases (NodeData/binary NodeData).


 Comments   
Comment by Tobias Mattsson [ 30/Nov/12 ]
  • Link
    • please change variable name repoName to workspaceName
    • throw RuntimeRepositoryException instead of RuntimeException
    • constructor Link(Node) doesn't throw RepositoryException as javadoc claims
    • method initLink, javadoc refers to not present parameter content
    • shouldn't we rename field repository to workspace and handle to path, provide new getters and setters, and keep the old ones for backwards compatibility?
  • LinkUtil
    • change variable name from repository to workspaceName
    • complete or remove javadoc like this:
          /**
           * 
           * @param nodeData
           * @return
           * @throws LinkException
           * @deprecated
           */
      
    • some @param directives in javadoc refer to parameters that dont exist, usually nodeDate when it should be node
    • toPattern, javadoc is incorrect, it doesn't throw RepositoryException
Generated at Mon Feb 12 03:57:38 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.