[MAGNOLIA-4648] Node2Bean: Allow specifying transformers via annotation Created: 06/Nov/12  Updated: 04/Aug/14  Resolved: 11/Dec/12

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: None
Fix Version/s: 5.0

Type: Improvement Priority: Neutral
Reporter: Jaroslav Simak Assignee: Jaroslav Simak
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MAGNOLIA-5865 @TransformedBy on setters can cause t... Closed
relation
is related to DOCU-346 Node2Bean: specifying transformers vi... Closed
is related to MAGNOLIA-4724 Node2Bean: improvements for transform... Closed
supersession
is superseded by MAGNOLIA-5263 Allow specifying transformer via @Tra... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Comments   
Comment by Jan Haderka [ 19/Nov/12 ]

There is no git commit associated with this ticket showing up. Can you please double check and provide signature of related commit(s).

For such change there should be associated documentation ticket created.

Comment by Jaroslav Simak [ 19/Nov/12 ]

Sorry, i forgot to add ticked number to commit message
https://git.magnolia-cms.com/gitweb/?p=magnolia_main.git;a=commit;h=d07215b27f96cce52e26e2ac8e08ffdce9b9d1d6
I will create docu ticket asap.

Comment by Tobias Mattsson [ 30/Nov/12 ]
  • Please clarify in the javadoc of @N2B how to use it, i assume its used on a setter to specify the transformer to use on the corresponding node?
  • When creating the transformer to use don't create the instance directly instead let the ComponentProvider do it so that the instance can benefit from dependency injection.
  • @N2B isn't a very good name, would be better if it was something like @Transformer, @Transformed, @TransformedBy, @NodeTransformer and has just a property named value so you didnt have to spell out transformer=MyTransformer.class
Generated at Mon Feb 12 03:57:42 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.