[MAGNOLIA-4701] Replace usage of MgnlNodeType (deprecated) & MetaData by new NodeTypes Created: 30/Nov/12  Updated: 11/Feb/13  Resolved: 08/Jan/13

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 5.0
Fix Version/s: 5.0

Type: Improvement Priority: Major
Reporter: Daniel Lipp Assignee: Daniel Lipp
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
depends upon MAGNOLIA-4747 Create new NodeType inner class repre... Closed
relation
is related to MGNLSTK-1059 Replace usage of MgnlNodeType (deprec... Closed
is related to MGNLUI-453 Replace usage of MgnlNodeType (deprec... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Comments   
Comment by Christopher Zimmermann [ 18/Dec/12 ]

Reviewed.

Comment by Daniel Lipp [ 20/Dec/12 ]

Once MAGNOLIA-4747 is fixed, we can also replace usages of MgnlNodeType#NT_METADATA.

In addition it looks like not all references to MgnlNodeType had been replaced before.

Comment by Christopher Zimmermann [ 08/Jan/13 ]

What about CopyUtil.removeNonExistingChildNodes() line 203?
"if (child.isNodeType(MgnlNodeType.MIX_REFERENCEABLE)) {"
> Should this be replaced with: JcrConstants.MIX_REFERENCEABLE ?

What about ItemType line 96
public static final String MIX_ACCESSCONTROLLABLE = MgnlNodeType.MIX_ACCESSCONTROLLABLE;
> Should something be created in NodeTypes for this?

ItemType line 117
public static final String MGNL_NODE_DATA = MgnlNodeType.MGNL_NODE_DATA;
> Should this not directly reference NodeTypes.NodeData.NAME ?

Comment by Daniel Lipp [ 08/Jan/13 ]

I actually overlooked CopyUtil #203 - will fix right now. The mentioned occurrences in ItemType where not replaced, because these are old constants that don't have a non-deprecated replacement. ItemType itself is deprecated so they'll got together with this type.

Generated at Mon Feb 12 03:58:12 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.