[MAGNOLIA-4711] Templating: Allow to omit the area node for structural areas by configuration only. Created: 05/Dec/12 Updated: 06/May/14 Resolved: 09/Apr/14 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | templating |
| Affects Version/s: | 4.5.6 |
| Fix Version/s: | 5.2.4 |
| Type: | Improvement | Priority: | Major |
| Reporter: | Philipp Bärfuss | Assignee: | Milan Divilek |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | maintenance, support | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||
| Release notes required: |
Yes
|
||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||
| Description |
|
Sometimes its not needed to have an area node. This is especially the case if the area is of type noComponents. Currently this is achieved by passing the current node (page for instance) to the area tag. Following an example of the main.ftl of the STK: [@cms.area name="branding" content=content/]
We should introduce the attribute (on the tag and the definition) to achieve the same. I suggest to add areaNode with default value true. |
| Comments |
| Comment by Milan Divilek [ 04/Apr/14 ] |
|
Introduced new attribute called createAreaNode with default value true. areaNode could be misleading. It already exist in info.magnolia.templating.elements.AreaElement for storing area Node (Node areaNode). |
| Comment by Christopher Zimmermann [ 08/Apr/14 ] |
|
Small thing: Please rename testCreateAreNode to testCreateAreaNode in TestAreaBarTagTest. |
| Comment by Antti Hietala [ 23/Apr/14 ] |
|
Documented the property and tag attribute. |