[MAGNOLIA-4718] Improve performance for SimpleUrlPattern Created: 07/Dec/12 Updated: 07/Feb/13 Resolved: 06/Feb/13 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | security |
| Affects Version/s: | 4.4.6 |
| Fix Version/s: | 4.4.10 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Ondrej Chytil | Assignee: | Ondrej Chytil |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Template: |
|
||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||
| Description |
|
SimpleUrlPattern check takes more time now due to reflection calls made to determine site. This can be improved. |
| Comments |
| Comment by Jan Haderka [ 06/Feb/13 ] |
|
I think it's perfect to deprecate shouldUseFullURI, but it is bit too harsh to throw exception when one tries to use it. Sure they will have performance issues when sticking to this method, but we should not stop them. |