[MAGNOLIA-4726] Array-Style GET Parameters break rendering Created: 12/Dec/12 Updated: 03/Dec/13 Resolved: 14/Dec/12 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | rendering |
| Affects Version/s: | 4.5 |
| Fix Version/s: | 4.5.8, 5.0 |
| Type: | Bug | Priority: | Major |
| Reporter: | Richard Unger | Assignee: | Jaroslav Simak |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | rendering, stk | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Magnolia 4.5 EE, CE running under Linux, but I doubt this affects the problem. |
||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||
| Date of First Response: | |||||||||||||
| Description |
|
Any request containing array-style GET parameters causes rendering to fail. Try it out using: For example, parameters are normally sent in this syntax when a form contains multiple checkboxes belonging to the same group. The Problem does not occur in Magnolia 4.4.8 |
| Comments |
| Comment by Jaroslav Simak [ 14/Dec/12 ] |
|
Commits for master branch (i forgot to add ticket number to commit message) |
| Comment by Jaroslav Simak [ 14/Dec/12 ] |
|
Reason why this fails in magnolia 4.5 is another version of org.apache.commons.beanutils.BeanUtils it uses. Method org.apache.commons.beanutils.BeanUtils.populate(Object, Map) expects a numeric index between square brackets. In older version of org.apache.commons.beanutils.BeanUtils when there is no index between those brackets nothing happens and processing goes on. In newer version an exception is thrown and rendering is stopped. What i also noticed is that if you send multiple values with same name in query string you will get only first one. Anyway .. square brackets in url are now handled as in 4.4. version and will not break rendering. |