[MAGNOLIA-4733] Create a generic PropertyFilteringNodeWrapper that filter property. Created: 17/Dec/12  Updated: 11/Feb/13  Resolved: 08/Jan/13

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 5.0
Fix Version/s: 5.0

Type: Task Priority: Neutral
Reporter: Eric Hechinger Assignee: Eric Hechinger
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLDAM-55 Create/Adapt migration task in order ... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

Create a PropertyFilteringNodeWrapper that filter Properties associated to a node that pass the following Predicate:
Property.getString() equals the constructor value.

If the value is set to null, properties with null value will be returned.



 Comments   
Comment by Federico Grilli [ 08/Jan/13 ]

Reopened after review.

  • Javadoc says "If value is set to null, return only properties that have a null value." but there's no test case covering that
  • info.magnolia.jcr.predicate.PropertyValueFilteringPredicateTest.testReturnsFalseOnException() does no assertion on the expected outcome
  • the copyright year should be 2013 (yes, I know this is nitpicking)

More on a side note, I think the name PropertyValueFilterPredicate is a bit confusing as it really only works with String properties but am not sure if, say, StringPropertyValueFilterPredicate would be better.

Generated at Mon Feb 12 03:58:31 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.