[MAGNOLIA-4778] Audit log is (partially) not working since 4.5 Created: 17/Jan/13  Updated: 24/Oct/13  Resolved: 09/May/13

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: None
Fix Version/s: 4.5.9

Type: Bug Priority: Critical
Reporter: Magnolia International Assignee: Milan Divilek
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MAGNOLIA-5421 MgnlAuditLoggingContentDecoratorNodeW... Closed
dependency
depends upon MAGNOLIA-4810 Wrappers don't wrap everything what s... Closed
relation
is related to MAGNOLIA-2730 Reimplement audit and security using ... Closed
is related to MAGNOLIA-5013 Add possibility into AuditLogging inf... Closed
is related to MAGNOLIA-5012 Add possibility into AuditLogging to ... Closed
is related to MAGNOLIA-4992 ContentDecorator can be lost if works... Closed
is related to MAGNOLIA-5022 Move auditing related code into info.... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

The audit log classes are only used used when using the Content API. When using the JCR APIs, it seems they're just never used.

This could be reimplemented by using the wrappers. I understand that all our session objects are already wrapped, so it shouldn't be too big a deal.

Also linking further improvement to the audit log API - to take into account, not necessarily implement as a fix to this issue.

Concept page: http://wiki.magnolia-cms.com/display/DEV/Concept+-+Move+AuditLog+from+Content+API+to+JCR+API



 Comments   
Comment by Magnolia International [ 03/May/13 ]

Also consider some of the issues linked to MAGNOLIA-2730

Comment by Magnolia International [ 08/May/13 ]

This is breaking a bunch of other builds/tests, among which DAM and Imaging.
Starting a quick review, and I stumbled upon this, which IMO has nothing to do in core:

if ("imaging".equals(logicalWorkspaceName) || "Expressions".equals(logicalWorkspaceName) || "Store".equals(logicalWorkspaceName)) {
    // don't wrap imaging, expression and store into audit logging session
    return new MgnlVersioningSession(session);
}

Stuff should be in info.magnolia.audit, not .logging

Generated at Mon Feb 12 03:58:57 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.