Commands refactoring (MAGNOLIA-4782)

[MAGNOLIA-4783] Move activation related commands to the Activation module Created: 21/Jan/13  Updated: 11/Feb/13  Resolved: 23/Jan/13

Status: Closed
Project: Magnolia
Component/s: activation
Affects Version/s: None
Fix Version/s: 5.0

Type: Sub-task Priority: Neutral
Reporter: Jozef Chocholacek Assignee: Federico Grilli
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLACTIVATION-8 Write more activation-related tests Closed
relation
is related to MGNLACTIVATION-7 Implement basic activation Closed
is related to MGNLACTIVATION-10 rewrite activation to use node api in... Closed
Template:
Release notes required:
Yes
Date of First Response:

 Description   
  1. Move BaseActivationCommand, ActivationCommand and DeactivationCommand classes to the Activation module.
  2. Move /modules/adminInterface/commands/default/activate and /modules/adminInterface/commands/default/deactivate command definitions (bootstrap files) to the Activation module.
  3. Update the Activation module's version handler to remove the above definitions on upgrade (and create the proper ones if needed).


 Comments   
Comment by Federico Grilli [ 21/Jan/13 ]

Re point #3 I just bootstrapped the new config w/o removing any node as I believe that will be part of new adminCentral update task which will most likely remove adminInterface en bloc.

Comment by Espen Jervidalo [ 23/Jan/13 ]

ticket does not or not only belong in MAGNOLIA -> link MGNLACTIVATION

info.magnolia.module.activation.commands.BaseActivationCommand:
javadoc
#ATTRIBUTE_SYNDICATOR never used
info.magnolia.cms.exchange.Syndicator#init deprecated
info.magnolia.cms.beans.config.ContentRepository deprecated

info.magnolia.module.activation.commands.ActivationCommand:
deserves better test coverage
Content deprecated

info.magnolia.module.activation.commands.ActivationCommand#activateUpdate
ctx never used
info.magnolia.module.activation.commands.ActivationCommand#activateRecursive
javadoc without javadoc:
/**

  • @param ctx
  • @param versionMap
  • */
    getHierarchyManager deprecated
    ctx, versions = null never used

info.magnolia.module.activation.commands.ActivationCommandTest:
using Content and HierarchyManager

info.magnolia.module.activation.commands.DeactivationCommand:
info.magnolia.cms.exchange.Syndicator#init deprecated
info.magnolia.cms.beans.config.ContentRepository deprecated
Content deprecated

modules/activation/src/test/java/info/magnolia/module/activation/setup
remove .emptydir-placeholder from git repo

Comment by Federico Grilli [ 23/Jan/13 ]

@Espen Thanks, this is all valuable input but I'd rather file a new issue for that (which I am going to do) than trying to fix everything in such a narrow-scope ticket. The thing is that it is quite a large work to rewrite all this stuff (Syndicator & friends) using Node and non deprecated stuff, tests included.

Generated at Mon Feb 12 03:58:59 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.