Commands refactoring (MAGNOLIA-4782)

[MAGNOLIA-4784] Move basic command classes to the Core module Created: 21/Jan/13  Updated: 11/Feb/13  Resolved: 24/Jan/13

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: None
Fix Version/s: 5.0

Type: Sub-task Priority: Neutral
Reporter: Jozef Chocholacek Assignee: Jozef Chocholacek
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MAGNOLIA-4794 Write test for RuleBasedCommand Closed
is related to MAGNOLIA-4795 Remove deprecated Content API from th... Closed
Template:
Release notes required:
Yes
Date of First Response:

 Description   

Move the BaseRepositoryCommand, RuleBasedCommand, DeleteCommand, VersionCommand, MarkNodeAsDeletedCommand and MessageCommand from the Admin Interface module to the info.magnolia.commands.impl package in the Core module.



 Comments   
Comment by Jozef Chocholacek [ 21/Jan/13 ]

pushed to the workflow branch

Comment by Jozef Chocholacek [ 21/Jan/13 ]

Forgot to move the tests.

Comment by Jozef Chocholacek [ 21/Jan/13 ]

Committed to workflow branch.

Comment by Espen Jervidalo [ 23/Jan/13 ]

from the ticket it's not clear where those classes come from, please update or link to ticket where they were removed

info.magnolia.commands.impl.DeleteCommand
deserves a testcase, MgnlContext.getHierarchyManager deprecated call

info.magnolia.commands.impl.MarkNodeAsDeletedCommand
Components.getSingleton deprecated, but maybe not possible without bigger change?
AccessDeniedException, PathNotFoundException, UnsupportedRepositoryOperationException all covered by repositoryException
Metadata, MgnlNodeType deprecated

info.magnolia.commands.impl.MarkNodeAsDeletedCommandTest
Metadata, MgnlNodeType deprecated

info.magnolia.commands.impl.RuleBasedCommand
deserves a testcase
#ATTRIBUTE_RULE never used
info.magnolia.cms.core.ItemType deprecated

info.magnolia.commands.impl.VersionCommand
AccessDeniedException covered by RepoException
Content and getNode deprecated

general: remove author and version from javadoc

Comment by Jozef Chocholacek [ 24/Jan/13 ]

More complex tasks from the review comment moved to MAGNOLIA-4794 and MAGNOLIA-4795

Generated at Mon Feb 12 03:59:00 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.