[MAGNOLIA-4786] Remove pooling capabilities from commands Created: 21/Jan/13  Updated: 20/Feb/15  Resolved: 04/Feb/13

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: None
Fix Version/s: 5.0

Type: Task Priority: Neutral
Reporter: Jozef Chocholacek Assignee: Jozef Chocholacek
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLMAIL-6 Adapt to info.magnolia.context.Contex... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

See http://wiki.magnolia-cms.com/display/DEV/Concept+-+Commands

The pooling capabilities will be removed from the MgnlCommand base class, and the CommandsManager will be changed to create new instance for each getCommand() or executeCommand() call.



 Comments   
Comment by Jozef Chocholacek [ 22/Jan/13 ]

I've also decided to remove the commons-chain dependencies, as the pooling has been quite bound to them (and vice-versa).

Comment by Mikaël Geljić [ 23/Jan/13 ]

Extreme review, just had a bunch of missing @Overrides on ChainBase (and MgnlCatalog as well actually), before finding out this is still in progress

Comment by Espen Jervidalo [ 29/Jan/13 ]

info.magnolia.commands.chain.*
one sentence explaining what the class does.

info.magnolia.commands.chain.ChainBase
remove // ----- constructor/fields etc
move fields up before constructor

info.magnolia.commands.chain.Catalog#CATALOG_KEY
not used, if it is, packaging wrong?

info.magnolia.commands.MgnlCatalog
remove // ----- constructor/fields etc

info.magnolia.commands.CommandTransformer
imports in wrong order, do you have the latest code stele settings for eclipse from federico?

magnolia_main/magnolia-core/pom.xml
reformatting is wrong, tabs are 2 spaces in xml files, please adjust your IDE settings

Generated at Mon Feb 12 03:59:01 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.